refactor!: TrackStateType as bitset view instead of bitset #2068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This decouples the storage a bit from the semantics. It allows the backends to store `uint64_t` and have the rest of the code transparently interpret this as a bitset.
andiwand
approved these changes
Apr 27, 2023
Codecov Report
@@ Coverage Diff @@
## main #2068 +/- ##
=======================================
Coverage 49.31% 49.31%
=======================================
Files 427 427
Lines 24808 24828 +20
Branches 11436 11444 +8
=======================================
+ Hits 12234 12245 +11
- Misses 4513 4514 +1
- Partials 8061 8069 +8
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for 5b784d6Full report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
|
Can you have another look @andiwand? |
andiwand
approved these changes
May 2, 2023
paulgessinger
removed this pull request from the merge queue due to the queue being cleared
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This decouples the storage a bit from the semantics. It allows the backends to store
uint64_tand have the rest of the code transparently interpret this as a bitset.