refactor: replace warning for unmatched particles with info #2071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andiwand
added
Component - Examples
|
Shouldn't you change the level to VERBOSE or DEBUG instead of INFO ? |
|
|
Codecov Report
@@ Coverage Diff @@
## main #2071 +/- ##
=======================================
Coverage 49.37% 49.37%
=======================================
Files 427 427
Lines 24779 24779
Branches 11430 11430
=======================================
Hits 12234 12234
Misses 4484 4484
Partials 8061 8061 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for 92c2666Full report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
benjaminhuth
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after #2049 we see a lot of warnings like
I believe they are cause by filtered truth particles which now produce hits and get reconstructed. the root writers then find the tracks with particles which are not in the list of selected ones
after discussion with @Corentin-Allaire and @benjaminhuth it makes most sense to me to just level down the log and guarantee that those tracks are flagged as fake