fix: Improve full chain pulls by enabling Fatras interactions #2086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Physics performance monitoring for b24e16eSummary VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalAMVF seededAMVF truth_smearedAMVF truth_estimatedAMVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
Codecov Report
@@ Coverage Diff @@
## main #2086 +/- ##
=======================================
Coverage 49.51% 49.51%
=======================================
Files 450 450
Lines 25465 25465
Branches 11718 11718
=======================================
Hits 12608 12608
Misses 4565 4565
Partials 8292 8292 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
|
|
somehow this crashes a bunch of things. need to take a closer look |
|
after discussion with @pbutti I decided to split this PR into smaller pieces |
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
I pulled this out of #2086 since it is not relevant there but I would still like to merge them. These changes are random improvements across the code base which should not have any effects on CPU or physics performance.
andiwand
changed the title
benjaminhuth
previously approved these changes
Jul 24, 2023
benjaminhuth
approved these changes
Jul 24, 2023
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Jul 24, 2023
I pulled this out of acts-project#2086 since it is not relevant there but I would still like to merge them. These changes are random improvements across the code base which should not have any effects on CPU or physics performance.
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Jul 24, 2023
…roject#2086) Our full chain pulls are in a bad state. Looks like the reconstruction and simulation energy loss did not match up. This PR switches the Fatras interactions on which should bring our pulls back to standard normal distribution. Fixes - acts-project#1643 Blocked by - acts-project#2157 - acts-project#2239 - acts-project#2295 - acts-project#2293 - acts-project#2294
LaraCalic
pushed a commit
to LaraCalic/acts
that referenced
this pull request
Feb 10, 2024
An initial track parameter covariance is necessary to avoid double counting and to estimate the covariance purely from the measurements. Pulled out of acts-project#2086 to see the individual effects. I added this to the ODD and ITk full chain and our physmon bocked by - acts-project#2829
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our full chain pulls are in a bad state. Looks like the reconstruction and simulation energy loss did not match up. This PR switches the Fatras interactions on which should bring our pulls back to standard normal distribution.
Fixes
Blocked by
LineSurfacetolerance inconsistency inglobalToLocal#2239