Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Use uint64_t explicitly in MultiTrajectory #2090

Merged
merged 2 commits into from
May 5, 2023
Merged

refactor: Use uint64_t explicitly in MultiTrajectory #2090

merged 2 commits into from
May 5, 2023

Conversation

paulgessinger
Copy link
Member

Was using unsigned long long before, but that's not actually guaranteed to be uint64_t on all platforms

@paulgessinger
refactor: Use uint64_t explicitly in MultiTrajectory
0f84f6c 
Was using `unsigned long long` before, but that's not actually
guaranteed to be `uint64_t` on all platforms
@paulgessinger paulgessinger added this to the next milestone May 5, 2023
@paulgessinger paulgessinger mentioned this pull request May 5, 2023
Merged
@codecov
Copy link

codecov bot commented May 5, 2023 •
edited

Codecov Report

Merging #2090 (05b9d39) into main (3ab60b5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2090   +/-   ##
=======================================
  Coverage   49.32%   49.32%           
=======================================
  Files         427      427           
  Lines       24830    24830           
  Branches    11444    11444           
=======================================
  Hits        12247    12247           
  Misses       4514     4514           
  Partials     8069     8069
Impacted Files Coverage Δ
Core/include/Acts/EventData/MultiTrajectory.hpp 71.32% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented May 5, 2023 •
edited

📊 Physics performance monitoring for 05b9d39

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@andiwand andiwand added Component - Core Affects the Core module automerge labels May 5, 2023
@kodiakhq kodiakhq bot merged commit d4d768f into acts-project:main May 5, 2023
58 checks passed
@github-actions github-actions bot removed the automerge label May 5, 2023
@paulgessinger paulgessinger modified the milestones: next, v26.0.0 May 22, 2023
kodiakhq bot pushed a commit that referenced this pull request Oct 23, 2023
@paulgessinger
feat: Add PODIO plugin, Track EDM backend (#2094)
db3ec38 
This PR adds a self-contained PODIO plugin, independent from the EDM4hep plugin. It implements backends for the `TrackContainer` and `MultiTrajectory` EDM. Tests are included for conversion of both EDM types.

Blocked by:
- #2093 
- #2092 
- #2091 
- #2090
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andiwand andiwand andiwand approved these changes

Assignees
No one assigned
Labels
Component - Core Affects the Core module
Projects
None yet
Milestone
v26.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paulgessinger @andiwand