Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Geant4 kill particle after configurable time #2097

Merged

Conversation

benjaminhuth
Copy link
Member

This adds an option to the particle killer to kill a particle after a certain time. Also applies this feature to the full-chain-example of the ODD with a (hopefully) reasonable value of 25ns.

@benjaminhuth benjaminhuth added the Component - Examples Affects the Examples module label May 5, 2023
@benjaminhuth benjaminhuth added this to the next milestone May 5, 2023
@benjaminhuth benjaminhuth requested a review from andiwand May 5, 2023 15:19
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is a really cool feature!

Examples/Algorithms/Geant4/src/ParticleKillAction.cpp Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #2097 (77af4cd) into main (2c02d29) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2097   +/-   ##
=======================================
  Coverage   49.44%   49.44%           
=======================================
  Files         436      436           
  Lines       25125    25125           
  Branches    11607    11607           
=======================================
  Hits        12424    12424           
  Misses       4467     4467           
  Partials     8234     8234           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented May 5, 2023

📊 Physics performance monitoring for 77af4cd

Summary
Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
AMVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

AMVF seeded

AMVF truth_smeared

AMVF truth_estimated

AMVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@andiwand
Copy link
Contributor

andiwand commented May 25, 2023

@benjaminhuth let me know if you need any help with getting this in

benjaminhuth and others added 2 commits May 25, 2023 10:37
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
@kodiakhq kodiakhq bot merged commit 672b144 into acts-project:main May 26, 2023
49 checks passed
@paulgessinger paulgessinger modified the milestones: next, v27.0.0 Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants