Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve propagator doc #2102

Merged
merged 3 commits into from
May 9, 2023

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented May 6, 2023

make PDG explicit and improve doc a little

@andiwand andiwand added the Component - Core Affects the Core module label May 6, 2023
@andiwand andiwand added this to the next milestone May 6, 2023
@codecov
Copy link

codecov bot commented May 6, 2023

Codecov Report

Merging #2102 (d4a759f) into main (44c343b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2102   +/-   ##
=======================================
  Coverage   49.41%   49.41%           
=======================================
  Files         434      434           
  Lines       24985    24985           
  Branches    11522    11522           
=======================================
  Hits        12347    12347           
  Misses       4486     4486           
  Partials     8152     8152           
Impacted Files Coverage Δ
Core/include/Acts/Propagator/Propagator.hpp 93.33% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented May 6, 2023

📊 Physics performance monitoring for d4a759f

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@kodiakhq
Copy link
Contributor

kodiakhq bot commented May 9, 2023

This PR could not be merged because the GitHub API returned an internal server error. To enable Kodiak on this pull request please remove the kodiak:disabled label.

When the GitHub API returns an internal server error (HTTP status code 500), it is not safe for Kodiak to retry merging.

For more information please see https://kodiakhq.com/docs/troubleshooting#merge-errors

If you need help, you can open a GitHub issue, check the docs, or reach us privately at support@kodiakhq.com.

docs | dashboard | support

@kodiakhq kodiakhq bot merged commit 6e613f0 into acts-project:main May 9, 2023
52 checks passed
@github-actions github-actions bot removed the automerge label May 9, 2023
@andiwand andiwand deleted the chore-improve-propagator-doc branch May 9, 2023 15:31
@paulgessinger paulgessinger modified the milestones: next, v26.0.0 May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants