Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add basic cmd options to physmon #2113

Merged
merged 3 commits into from
May 10, 2023

Conversation

benjaminhuth
Copy link
Member

@benjaminhuth benjaminhuth commented May 9, 2023

In order to debug physmon issues, I rarely need to run the whole suite, which is very time consuming. This adds a basic cmd interface to select certain tasks (not to fine-grained). It's a bit ugly, but it's bash...

@benjaminhuth benjaminhuth added the Infrastructure Changes to build tools, continous integration, ... label May 9, 2023
@benjaminhuth benjaminhuth added this to the next milestone May 9, 2023
@paulgessinger
Copy link
Member

paulgessinger commented May 9, 2023

Could we not split up the scripts maybe? I'll be looking at adding ttbar jobs soon anyway, where I'll probably have to do something like that anyway.

Concretely I'll likely split the generation of validation output and collection and plotting. Maybe that would be an option?

@benjaminhuth
Copy link
Member Author

You mean like having something like:

physmon_truth_tracking.py
physmon_gsf.py
...

Yeah would be event better I think. I thought I go for the "least-impact" version, but a larger restructuring would be even better.
Maybe we could also get rid of the bash code at this point?

@paulgessinger
Copy link
Member

The bash script does copying and runs the plotting if needed, so I'd probably keep that in some form.

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #2113 (e5de8f4) into main (532272e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2113   +/-   ##
=======================================
  Coverage   49.42%   49.42%           
=======================================
  Files         434      434           
  Lines       24986    24986           
  Branches    11516    11516           
=======================================
  Hits        12350    12350           
  Misses       4491     4491           
  Partials     8145     8145           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented May 9, 2023

📊 Physics performance monitoring for e5de8f4

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@benjaminhuth
Copy link
Member Author

I agree, but actually I would like to merge this in this state to have something like this in the repo at all...

Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this makes your workflow easier I think it is good enough for now

I wonder if we could merge the bash and python into a single python thing in the future

@kodiakhq kodiakhq bot merged commit 6e9fad6 into acts-project:main May 10, 2023
51 of 52 checks passed
paulgessinger added a commit to paulgessinger/acts that referenced this pull request May 11, 2023
@paulgessinger paulgessinger modified the milestones: next, v26.0.0 May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants