-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add basic cmd options to physmon #2113
ci: Add basic cmd options to physmon #2113
Conversation
Could we not split up the scripts maybe? I'll be looking at adding ttbar jobs soon anyway, where I'll probably have to do something like that anyway. Concretely I'll likely split the generation of validation output and collection and plotting. Maybe that would be an option? |
You mean like having something like:
Yeah would be event better I think. I thought I go for the "least-impact" version, but a larger restructuring would be even better. |
The |
Codecov Report
@@ Coverage Diff @@
## main #2113 +/- ##
=======================================
Coverage 49.42% 49.42%
=======================================
Files 434 434
Lines 24986 24986
Branches 11516 11516
=======================================
Hits 12350 12350
Misses 4491 4491
Partials 8145 8145 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for e5de8f4Full report VertexingSeedingCKFAmbiguity resolutionTruth tracking (Kalman Filter)Truth tracking (GSF) |
I agree, but actually I would like to merge this in this state to have something like this in the repo at all... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this makes your workflow easier I think it is good enough for now
I wonder if we could merge the bash and python into a single python thing in the future
This reverts commit 6e9fad6.
In order to debug physmon issues, I rarely need to run the whole suite, which is very time consuming. This adds a basic cmd interface to select certain tasks (not to fine-grained). It's a bit ugly, but it's bash...