fix: Remove det(cov)<=0 check from HelicalTrackLinearizer #2127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andiwand
added
Component - Core
Codecov Report
@@ Coverage Diff @@
## main #2127 +/- ##
==========================================
+ Coverage 49.45% 49.46% +0.01%
==========================================
Files 434 434
Lines 25019 25012 -7
Branches 11529 11522 -7
==========================================
Hits 12373 12373
+ Misses 4494 4488 -6
+ Partials 8152 8151 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
looks like this also recovers AMFV efficiency
|
📊 Physics performance monitoring for ba7f502Summary VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
|
/cc @pbutti @russofel |
pbutti
approved these changes
May 16, 2023
|
I had to update the reference @pbutti - could you reapprove? |
benjaminhuth
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMO this check should be removed as
det(cov)<=0should never be true anyways and replacing it with a different cov will not improve things. I logged into this usingfull_chain_odd.pyand it looks likedet(cov)<=0will fire a bunch of times because of numerical issues and the backup cov will also havedet(cov)<=0