fix: Protection against wrong configuration of Seed finder config

[CarloVarni]

In case a misconfiguration of the SeedFinderConfig happens, and the seedFilter is a nullptr, the code crashes.

This PR adds a protection against this eventuality. This happens in the toInternalUnits function, that now takes responsibility for checking the validity of its parameters.

It checks that the seedFilter is not a nullptr and that its config is already in internal units.

[github-actions]

📊 Physics performance monitoring for ea16fb6

Summary
Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
AMVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu

IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

AMVF seeded

AMVF truth_smeared

AMVF truth_estimated

AMVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

[codecov]

Codecov Report

Merging #2129 (ea16fb6) into main (672b144) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2129   +/-   ##
=======================================
  Coverage   49.44%   49.44%           
=======================================
  Files         436      436           
  Lines       25125    25125           
  Branches    11607    11607           
=======================================
  Hits        12424    12424           
  Misses       4467     4467           
  Partials     8234     8234           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[paulgessinger]

Looks good to me. You were wondering if we ever want to actually configure the finder without the filter, I guess we don't? Thoughts @LuisFelipeCoelho ?

[LuisFelipeCoelho]

I also don't see why we would want to configure the seed finder without the filter. In any case, we can configure the filter to keep all seeds.

[andiwand]

looks like our tests rely on this 🤔

[CarloVarni]

ok, then I'll get a look at the failures here and fix them. It looks like indeed we have situation where the filter is not set

[CarloVarni]

I forgot in the previous commit to propagate the changes in the SeedingAlgorithm example to this MR. Now it all works

[andiwand]

great, thank you!

[paulgessinger]

This whole "internal units" mechanism is a bit of a crux that we should be looking to remove. That's independent of this change though.