Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update physmon comment after vertexing monitoring changes #2130

Conversation

andiwand
Copy link
Contributor

after merging a bunch of vertexing monitoring improvements the physmon comment should also catch up

@andiwand andiwand added this to the next milestone May 16, 2023
@github-actions
Copy link

github-actions bot commented May 16, 2023

📊 Physics performance monitoring for a56d6c6

🟥 ERROR The result has missing elements!
This is likely a physmon job failure

Summary
Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

🖼️ ivf_seeded_plots/diffx.pdf ❌🖼️ ivf_seeded_plots/diffy.pdf ❌🖼️ ivf_seeded_plots/diffz.pdf ❌

IVF truth_smeared

🖼️ ivf_truth_smeared_plots/diffx.pdf ❌🖼️ ivf_truth_smeared_plots/diffy.pdf ❌🖼️ ivf_truth_smeared_plots/diffz.pdf ❌

IVF truth_estimated

🖼️ ivf_truth_estimated_plots/diffx.pdf ❌🖼️ ivf_truth_estimated_plots/diffy.pdf ❌🖼️ ivf_truth_estimated_plots/diffz.pdf ❌

IVF orthogonal

🖼️ ivf_orthogonal_plots/diffx.pdf ❌🖼️ ivf_orthogonal_plots/diffy.pdf ❌🖼️ ivf_orthogonal_plots/diffz.pdf ❌

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #2130 (b2e0f8d) into main (9e65ec3) will not change coverage.
The diff coverage is n/a.

❗ Current head b2e0f8d differs from pull request most recent head a56d6c6. Consider uploading reports for the commit a56d6c6 to get more accurate results

@@           Coverage Diff           @@
##             main    #2130   +/-   ##
=======================================
  Coverage   49.45%   49.45%           
=======================================
  Files         434      434           
  Lines       25019    25019           
  Branches    11529    11529           
=======================================
  Hits        12373    12373           
  Misses       4494     4494           
  Partials     8152     8152           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@benjaminhuth benjaminhuth added Infrastructure Changes to build tools, continous integration, ... automerge labels May 16, 2023
@kodiakhq kodiakhq bot merged commit 1f7a6c0 into acts-project:main May 16, 2023
52 checks passed
@andiwand andiwand deleted the chore-update-physmon-comment-after-vertexing-monitoring-changes branch May 16, 2023 20:18
kodiakhq bot pushed a commit that referenced this pull request May 17, 2023
kodiakhq bot pushed a commit that referenced this pull request May 19, 2023
another problem I try to fix after #2130
@paulgessinger paulgessinger modified the milestones: next, v26.0.0 May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge priority Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants