Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use time in IVF fitting #2145

Merged

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented May 24, 2023

For some reason we truncate the covariance in order to remove time before the vertex fitting. This might be causing problems in the full billoir fitter because the inverse of the covariance is not well conditions.

@andiwand andiwand added Component - Core Affects the Core module 🚧 WIP Work-in-progress labels May 24, 2023
@andiwand andiwand added this to the next milestone May 24, 2023
@github-actions
Copy link

github-actions bot commented May 24, 2023

📊 Physics performance monitoring for 0873219

Summary
Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
AMVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

AMVF seeded

AMVF truth_smeared

AMVF truth_estimated

AMVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@andiwand
Copy link
Contributor Author

this seems only to work in combination with #2137

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #2145 (65896a0) into main (fa36abf) will decrease coverage by 0.01%.
The diff coverage is 16.07%.

❗ Current head 65896a0 differs from pull request most recent head 0873219. Consider uploading reports for the commit 0873219 to get more accurate results

@@            Coverage Diff             @@
##             main    #2145      +/-   ##
==========================================
- Coverage   49.48%   49.48%   -0.01%     
==========================================
  Files         439      439              
  Lines       25130    25126       -4     
  Branches    11600    11599       -1     
==========================================
- Hits        12436    12433       -3     
  Misses       4443     4443              
+ Partials     8251     8250       -1     
Impacted Files Coverage Δ
.../include/Acts/Vertexing/HelicalTrackLinearizer.ipp 19.23% <0.00%> (+0.48%) ⬆️
...include/Acts/Vertexing/FullBilloirVertexFitter.ipp 26.75% <16.36%> (-1.56%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andiwand andiwand requested a review from pbutti May 24, 2023 15:50
@andiwand
Copy link
Contributor Author

removed the changes from #2137 now

@andiwand
Copy link
Contributor Author

andiwand commented Jun 5, 2023

checked the output again - IVF seems to pick up time and fits it. AMVF does not - I suspect that the KF updater also needs some changes. I would leave this for another PR to change

updating reference

@andiwand andiwand changed the title refactor: Use time in vertex fitting refactor: Use time in IVF fitting Jun 6, 2023
@kodiakhq kodiakhq bot merged commit 33e3e32 into acts-project:main Jun 6, 2023
48 checks passed
@github-actions github-actions bot removed the automerge label Jun 6, 2023
@andiwand andiwand deleted the refactor-use-time-in-vertex-fitting branch June 7, 2023 08:04
@paulgessinger paulgessinger modified the milestones: next, v27.0.0 Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants