-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Use time in IVF fitting #2145
refactor: Use time in IVF fitting #2145
Conversation
also remove workarounds in GainMatrix* and add proper loggers in CombinatorialKalmanFilter
📊 Physics performance monitoring for 0873219Summary VertexingSeedingCKFAmbiguity resolutionTruth tracking (Kalman Filter)Truth tracking (GSF) |
…cts into refactor-use-time-in-vertex-fitting
this seems only to work in combination with #2137 |
Codecov Report
@@ Coverage Diff @@
## main #2145 +/- ##
==========================================
- Coverage 49.48% 49.48% -0.01%
==========================================
Files 439 439
Lines 25130 25126 -4
Branches 11600 11599 -1
==========================================
- Hits 12436 12433 -3
Misses 4443 4443
+ Partials 8251 8250 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…-time-in-vertex-fitting
removed the changes from #2137 now |
checked the output again - IVF seems to pick up time and fits it. AMVF does not - I suspect that the KF updater also needs some changes. I would leave this for another PR to change updating reference |
For some reason we truncate the covariance in order to remove time before the vertex fitting. This might be causing problems in the full billoir fitter because the inverse of the covariance is not well conditions.