feat: Safe Eigen matrix inverse #2151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2151 +/- ##
==========================================
+ Coverage 49.44% 49.46% +0.01%
==========================================
Files 436 436
Lines 25125 25129 +4
Branches 11607 11606 -1
==========================================
+ Hits 12424 12431 +7
+ Misses 4467 4464 -3
Partials 8234 8234
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for 808fd85Summary VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalAMVF seededAMVF truth_smearedAMVF truth_estimatedAMVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
Co-authored-by: Paul Gessinger <hello@paulgessinger.com>
andiwand
commented
May 25, 2023
paulgessinger
approved these changes
May 26, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
May 27, 2023
In #2151 I discovered that modifying `Helpers.hpp` basically triggers a full rebuild and that we put a bunch of different stuff into it. In this PR I try to improve things by splitting up `Helpers.hpp` into multiple headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussion in #2122 and offline we decided to add a safe inverse that can be used in special occasions to avoid FPEs being thrown in order to handle them in a different, more controlled way.
The main motivation for this is that Athena has a very strict FPE policy which marks every occurrence as a job failure. Since we are dealing with a high number of events a certain number of inverse failures would be acceptable and should not be treated as a fatality.