-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Smearing-digitization with Geant4 #2182
fix: Smearing-digitization with Geant4 #2182
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great - thank you!
Fatras/include/ActsFatras/Digitization/UncorrelatedHitSmearer.hpp
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #2182 +/- ##
=======================================
Coverage 49.41% 49.41%
=======================================
Files 441 441
Lines 25176 25176
Branches 11617 11617
=======================================
Hits 12441 12441
Misses 4481 4481
Partials 8254 8254 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
📊 Physics performance monitoring for e218f2eSummary VertexingSeedingCKFAmbiguity resolutionTruth tracking (Kalman Filter)Truth tracking (GSF) |
Geant4 hits may not be exactely on the surface. This PR adjusts the tolerance for the free-to-bound conversion to address this. Also bumps the corresponding log message to a warning.
The error still occurs around 40 times for 2000 muons... but at least we are not loosing around 50% of the hits anymore...
cc @asalzburger