fix: and refactor Exa.TrkX plugin #2192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2192 +/- ##
=======================================
Coverage 49.36% 49.36%
=======================================
Files 445 445
Lines 25259 25259
Branches 11646 11646
=======================================
Hits 12468 12468
Misses 4511 4511
Partials 8280 8280 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
added 2 commits
June 9, 2023 18:02
📊 Physics performance monitoring for 286548fSummary VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalAMVF seededAMVF truth_smearedAMVF truth_estimatedAMVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
andiwand
added
Component - Examples
benjaminhuth
changed the title
andiwand
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the plugin by adding an important feature that was lost during the last refactoring. It is now possible to run run the edge classification undirected (feeding a bi-directional graph into the model).
Besides this, the code is refactored (logger for each module, variable names, added some warnings and debug output...)