refactor: TrackStateType safety, bitsize, conversion #2201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2201 +/- ##
==========================================
- Coverage 49.33% 49.32% -0.02%
==========================================
Files 441 441
Lines 25207 25208 +1
Branches 11622 11626 +4
==========================================
- Hits 12436 12433 -3
Misses 4513 4513
- Partials 8258 8262 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
andiwand
approved these changes
Jun 13, 2023
📊 Physics performance monitoring for afd9f5aSummary VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalAMVF seededAMVF truth_smearedAMVF truth_estimatedAMVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
paulgessinger
commented
Jun 14, 2023
benjaminhuth
approved these changes
Jun 14, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 6, 2023
We use a lot of memory in busy events, e.g. for ttbar pu200 we use multiple gigabytes of track state storage. This PR reduces this by rolling a track selection into the track finding algorithm. The CKF now operates on a temporary track container that is cleared between seeds and reused. Only tracks that pass the selection are copied into the output collection. In my testing this reduces the memory consumption by about 2x. Before:  After:  Blocked by: - #2202 - #2201 - #2203 - #2204 - #2205 - #2267
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes TrackStateType check it's internal pointer, fixes the size of the bitset used for manipulation, and allow auto-conversion from mutable to const.