Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: write unbiased residual for each track state #2238

Merged
merged 11 commits into from
Aug 16, 2023

Conversation

XiaocongAi
Copy link
Contributor

This PR calculates the unbiased residual for track state using smoothed track parameters and measurement according to Eq.(12a)-Eq.(12c) in NIMA 262, 444, which can be used to validate the performance of alignment algorithm. This is implemented in the RootTrajectoryStatesWriter instead of a functionality in the Core as all the ingredients for the calculation are available in the KalmanFiltterResult.

This does not change any public API as defined in docs/versioning.rst.

@github-actions github-actions bot added the Component - Examples Affects the Examples module label Jun 23, 2023
@XiaocongAi XiaocongAi added this to the next milestone Jun 23, 2023
AJPfleger
AJPfleger previously approved these changes Jun 23, 2023
Copy link
Contributor

@AJPfleger AJPfleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
Maybe you can change the (c) in line 3 of both files to `2019-2023

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #2238 (c21fc44) into main (342899b) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #2238   +/-   ##
=======================================
  Coverage   49.57%   49.57%           
=======================================
  Files         453      453           
  Lines       25513    25513           
  Branches    11707    11707           
=======================================
  Hits        12649    12649           
  Misses       4579     4579           
  Partials     8285     8285           
Files Changed Coverage Δ
...nclude/Acts/Utilities/GaussianMixtureReduction.hpp 38.46% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot added the Stale label Jul 23, 2023
@paulgessinger
Copy link
Member

I think we expect these not to show up in the physmon output, since we don't currently monitor the hit residuals.

@acts-policybot acts-policybot bot dismissed AJPfleger’s stale review August 3, 2023 15:26

Invalidated by push of e7d7af2

@paulgessinger
Copy link
Member

I resolve the conflicts and bumped the copyright. This also looks good from my side. Can you reapprove @AJPfleger?

AJPfleger
AJPfleger previously approved these changes Aug 3, 2023
@paulgessinger
Copy link
Member

This fails due to FPEs and reference output changes.

@acts-policybot acts-policybot bot dismissed AJPfleger’s stale review August 4, 2023 11:57

Invalidated by push of 30be040

@github-actions github-actions bot added Component - Core Affects the Core module Component - Fatras Affects the Fatras module labels Aug 4, 2023
AJPfleger
AJPfleger previously approved these changes Aug 8, 2023
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Aug 14, 2023

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

@benjaminhuth benjaminhuth merged commit 4a8a7ee into acts-project:main Aug 16, 2023
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes Performance Component - Core Affects the Core module Component - Examples Affects the Examples module Component - Fatras Affects the Fatras module Fails Athena tests This PR causes a failure in the Athena tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Measurement removal to get unbiased residual during smoothing
6 participants