-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: write unbiased residual for each track state #2238
perf: write unbiased residual for each track state #2238
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Maybe you can change the (c) in line 3 of both files to `2019-2023
Codecov Report
@@ Coverage Diff @@
## main #2238 +/- ##
=======================================
Coverage 49.57% 49.57%
=======================================
Files 453 453
Lines 25513 25513
Branches 11707 11707
=======================================
Hits 12649 12649
Misses 4579 4579
Partials 8285 8285
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊: Physics performance monitoring for c21fc44physmon summary
|
I think we expect these not to show up in the physmon output, since we don't currently monitor the hit residuals. |
Invalidated by push of e7d7af2
I resolve the conflicts and bumped the copyright. This also looks good from my side. Can you reapprove @AJPfleger? |
This fails due to FPEs and reference output changes. |
Invalidated by push of 30be040
This PR currently has a merge conflict. Please resolve this and then re-add the |
Invalidated by push of 5d41203
This PR calculates the unbiased residual for track state using smoothed track parameters and measurement according to Eq.(12a)-Eq.(12c) in NIMA 262, 444, which can be used to validate the performance of alignment algorithm. This is implemented in the
RootTrajectoryStatesWriter
instead of a functionality in theCore
as all the ingredients for the calculation are available in theKalmanFiltterResult
.This does not change any public API as defined in
docs/versioning.rst
.