refactor!: Disambiguate surface intersection solutions #2336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Fatras
andiwand
changed the title
Codecov Report
@@ Coverage Diff @@
## main #2336 +/- ##
==========================================
+ Coverage 49.81% 49.88% +0.06%
==========================================
Files 466 466
Lines 26190 26232 +42
Branches 12009 12014 +5
==========================================
+ Hits 13047 13086 +39
+ Misses 4620 4614 -6
- Partials 8523 8532 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…ambiguate-intersection
…ambiguate-intersection
andiwand
changed the title
|
this is causing navigation failure in the |
|
this seems to work now - even tho I am not super happy with the fix but I don't see an alternative |
andiwand
commented
Sep 22, 2023
|
Is this why the physmon still shows differences? |
I just didn't update the reference yet because I was unsure if this one or #2470 should go in first |
github-actions
bot
added
the
Infrastructure
paulgessinger
approved these changes
Sep 22, 2023
acts-project-service
added
the
Breaks Athena build
|
This does break compilation in the material track writer in Athena. |
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 25, 2023
reopened #2318 after #2321 The CKF did not pick up the material in-between the first surface and the target surface. This PR is trying to fix that. Note: I had to use a not so nice hack and call the navigation pre step routine before we step towards the target. I don't see an easy way around that. blocked by - #2336
AJPfleger
pushed a commit
to AJPfleger/acts
that referenced
this pull request
Sep 29, 2023
…2336) Currently our intersection call can give an alternative solution but it is not clear which one is to be preferred in which situation and the results are unstable meaning that it could be swapped depending on where you are on the ray. Here I try to make the interface cleaner and the intersection order stable. blocked by - acts-project#2366 - acts-project#2368 --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: Benjamin Huth <37871400+benjaminhuth@users.noreply.github.com> Co-authored-by: Benjamin Huth <benjamin.huth@physik.uni-regensburg.de> Co-authored-by: Paul Gessinger <hello@paulgessinger.com>
AJPfleger
pushed a commit
to AJPfleger/acts
that referenced
this pull request
Sep 29, 2023
reopened acts-project#2318 after acts-project#2321 The CKF did not pick up the material in-between the first surface and the target surface. This PR is trying to fix that. Note: I had to use a not so nice hack and call the navigation pre step routine before we step towards the target. I don't see an easy way around that. blocked by - acts-project#2336
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently our intersection call can give an alternative solution but it is not clear which one is to be preferred in which situation and the results are unstable meaning that it could be swapped depending on where you are on the ray.
Here I try to make the interface cleaner and the intersection order stable.
blocked by