refactor: use map instead of two vectors in AdaptiveGridTrackDensity

[felix-russo]

Previously:
We used a vector containing z bins and a separate vector containing the corresponding density values.

Now:
We use a map relating
z bin -> density value

Future:
We will use a map relating
(z bin, time bin) -> density value
to include time information in the vertex finding.

[github-actions]

📊: Physics performance monitoring for 9dd1a00

Full contents

physmon summary

• ✅ Ambisolver orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver
• ✅ AMVF orthogonal
• ✅ AMVF seeded
• ✅ AMVF truth_estimated
• ✅ AMVF truth_smeared
• ✅ AMVF ttbar
• ✅ CKF orthogonal
• ✅ CKF seeded
• ✅ CKF truth_estimated
• ✅ CKF truth_smeared
• ✅ CKF ttbar
• ✅ Truth tracking (GSF)
• ✅ IVF orthogonal
• ✅ IVF seeded
• ✅ IVF truth_estimated
• ✅ IVF truth_smeared
• ✅ Particles final fatras
• ✅ Particles final geant4
• ✅ Particles inital fatras
• ✅ Particles inital geant4
• ✅ Seeding orthogonal
• ✅ Seeding seeded
• ✅ Seeding truth_estimated
• ✅ Seeding ttbar
• ✅ Track Summary CKF orthogonal
• ✅ Track Summary CKF seeded
• ✅ Track Summary CKF truth_estimated
• ✅ Track Summary CKF truth_smeared
• ✅ Truth tracking

[codecov]

Codecov Report

Merging #2338 (9dd1a00) into main (7ae364d) will decrease coverage by 0.06%.
The diff coverage is 52.74%.

@@            Coverage Diff             @@
##             main    #2338      +/-   ##
==========================================
- Coverage   49.63%   49.57%   -0.06%     
==========================================
  Files         453      453              
  Lines       25530    25511      -19     
  Branches    11705    11706       +1     
==========================================
- Hits        12672    12648      -24     
  Misses       4579     4579              
- Partials     8279     8284       +5     

Files Changed	Coverage Δ
...Acts/Vertexing/AdaptiveGridDensityVertexFinder.hpp	100.00% <ø> (ø)
...nclude/Acts/Vertexing/AdaptiveGridTrackDensity.hpp	100.00% <ø> (ø)
...Acts/Vertexing/AdaptiveGridDensityVertexFinder.ipp	50.63% <30.00%> (-2.38%)	⬇️
...nclude/Acts/Vertexing/AdaptiveGridTrackDensity.ipp	62.40% <55.55%> (-7.19%)	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[andiwand]

one general comment: it might be worth looking at flat implementations like the one from boost if this is performance critical

[felix-russo]

one general comment: it might be worth looking at flat implementations like the one from boost if this is performance critical

Yes, @paulgessinger made the same remark in the last stand-up meeting!

We agreed to the following:
I will first check if the physics performance improves after adding the time vertex seeding. Once the physmon looks good, I will investigate the CPU performance of the different implementations (i.e., unordered_map and Eigen SparseMatrix). Does this sound sensible?

[baschlag]

Looks good to me!

[acts-project-service]

✅ Athena integration test results

✅ All tests successful

status	job
🟢	run_unit_tests
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data