-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Build physmon summary from explicit report information #2350
ci: Build physmon summary from explicit report information #2350
Conversation
The inline image display has not really worked unfortunately, so this PR changes the comment to be largely consisting of the summary markdown output from the physmon job itself.
Codecov Report
@@ Coverage Diff @@
## main #2350 +/- ##
=======================================
Coverage 49.57% 49.57%
=======================================
Files 453 453
Lines 25513 25513
Branches 11707 11707
=======================================
Hits 12649 12649
Misses 4579 4579
Partials 8285 8285 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊: Physics performance monitoring for f6d0c9dphysmon summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - one minor comment
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
This has conflicts since #2282 I'll fix them tomorrow. |
Conflicts resolved now. |
The bash script now writes a CSV file that the summary script consumes. This should also help us in case files are missing: the summary should show them as missing.