Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Build physmon summary from explicit report information #2350

Merged
merged 28 commits into from
Aug 16, 2023

Conversation

paulgessinger
Copy link
Member

The bash script now writes a CSV file that the summary script consumes. This should also help us in case files are missing: the summary should show them as missing.

@paulgessinger paulgessinger added this to the next milestone Aug 4, 2023
@github-actions github-actions bot added the Infrastructure Changes to build tools, continous integration, ... label Aug 4, 2023
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #2350 (f6d0c9d) into main (4a8a7ee) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2350   +/-   ##
=======================================
  Coverage   49.57%   49.57%           
=======================================
  Files         453      453           
  Lines       25513    25513           
  Branches    11707    11707           
=======================================
  Hits        12649    12649           
  Misses       4579     4579           
  Partials     8285     8285           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

andiwand
andiwand previously approved these changes Aug 14, 2023
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - one minor comment

CI/physmon/summary.py Outdated Show resolved Hide resolved
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
@paulgessinger
Copy link
Member Author

This has conflicts since #2282 I'll fix them tomorrow.

@paulgessinger
Copy link
Member Author

Conflicts resolved now.

@benjaminhuth benjaminhuth merged commit 9cd59fd into acts-project:main Aug 16, 2023
55 checks passed
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Aug 16, 2023
@paulgessinger paulgessinger modified the milestones: next, v28.2.0 Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fails Athena tests This PR causes a failure in the Athena tests Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants