Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Add CalibrationContext to calibrator signature #2354

Merged
merged 8 commits into from
Aug 25, 2023

Conversation

paulgessinger
Copy link
Member

@paulgessinger paulgessinger commented Aug 8, 2023

This is currently unused by the calibrators, but should allow the calibrator to become
conditions-aware.

Blocked by:

Closes #2274

@paulgessinger paulgessinger added this to the v29.0.0 milestone Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #2354 (c06c440) into main (32e0119) will increase coverage by 0.01%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##             main    #2354      +/-   ##
==========================================
+ Coverage   49.52%   49.53%   +0.01%     
==========================================
  Files         453      453              
  Lines       25686    25692       +6     
  Branches    11818    11818              
==========================================
+ Hits        12721    12727       +6     
  Misses       4583     4583              
  Partials     8382     8382              
Files Changed Coverage Δ
Core/include/Acts/TrackFitting/GsfOptions.hpp 100.00% <ø> (ø)
...e/Acts/TrackFitting/detail/KalmanUpdateHelpers.hpp 18.96% <0.00%> (ø)
.../Acts/TrackFitting/detail/VoidKalmanComponents.hpp 26.66% <ø> (ø)
...de/Acts/TrackFinding/CombinatorialKalmanFilter.hpp 32.01% <50.00%> (+0.15%) ⬆️
Core/include/Acts/TrackFitting/KalmanFitter.hpp 43.22% <60.00%> (+0.32%) ⬆️
...nclude/Acts/TrackFitting/GlobalChiSquareFitter.hpp 39.39% <66.66%> (+0.74%) ⬆️
Core/include/Acts/TrackFitting/detail/GsfActor.hpp 45.14% <66.66%> (+0.17%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

andiwand
andiwand previously approved these changes Aug 14, 2023
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine by me - left two minor comments

Core/include/Acts/TrackFitting/KalmanFitter.hpp Outdated Show resolved Hide resolved
@andiwand andiwand added the 🛑 blocked This item is blocked by another item label Aug 14, 2023
@paulgessinger paulgessinger changed the title refactor: Add CalibrationContext to calibrator signature refactor!: Add CalibrationContext to calibrator signature Aug 14, 2023
@paulgessinger paulgessinger removed the 🛑 blocked This item is blocked by another item label Aug 24, 2023
paulgessinger and others added 4 commits August 25, 2023 13:02
This is currently unused, but should allow the calibrator to become
conditions-aware.
@paulgessinger
Copy link
Member Author

Rebased and updated. Should hopefully clear the CI now.

Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
benjaminhuth
benjaminhuth previously approved these changes Aug 25, 2023
Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get it in!

benjaminhuth
benjaminhuth previously approved these changes Aug 25, 2023
@paulgessinger
Copy link
Member Author

Had one more conflict from #2356 which should be gone now.

@kodiakhq kodiakhq bot merged commit 77ca0e8 into acts-project:main Aug 25, 2023
56 checks passed
@acts-project-service
Copy link
Collaborator

🔴 Athena integration test results

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaks Athena build This PR breaks the Athena build Component - Core Affects the Core module Component - Examples Affects the Examples module Event Data Model Track Finding Track Fitting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: add CalibrationContext to (C)KF interface, pass to calibrator
4 participants