Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Monitor grid seeding #2355

Merged
merged 29 commits into from
Aug 18, 2023
Merged

Conversation

felix-russo
Copy link
Contributor

Since we will extend the adaptive grid seeder to accommodate time seeding, I propose to add it to the physmon.

@github-actions github-actions bot added Component - Core Affects the Core module Infrastructure Changes to build tools, continous integration, ... Component - Examples Affects the Examples module Vertexing labels Aug 8, 2023
@felix-russo felix-russo changed the title CI: Monitor grid seeding ci: Monitor grid seeding Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #2355 (78b6434) into main (975b104) will increase coverage by 0.00%.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##             main    #2355   +/-   ##
=======================================
  Coverage   49.58%   49.58%           
=======================================
  Files         453      453           
  Lines       25511    25517    +6     
  Branches    11704    11706    +2     
=======================================
+ Hits        12649    12653    +4     
- Misses       4580     4581    +1     
- Partials     8282     8283    +1     
Files Changed Coverage Δ
Core/include/Acts/Utilities/AlgebraHelpers.hpp 59.67% <66.66%> (+0.74%) ⬆️
...nclude/Acts/Vertexing/AdaptiveGridTrackDensity.ipp 62.40% <100.00%> (ø)
...nclude/Acts/Vertexing/GaussianGridTrackDensity.ipp 67.93% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@felix-russo felix-russo marked this pull request as ready for review August 9, 2023 17:00
@andiwand andiwand added this to the next milestone Aug 15, 2023
Examples/Python/src/Vertexing.cpp Outdated Show resolved Hide resolved
Examples/Python/src/Vertexing.cpp Outdated Show resolved Hide resolved
Examples/Python/src/Vertexing.cpp Outdated Show resolved Hide resolved
Core/include/Acts/Vertexing/AdaptiveGridTrackDensity.ipp Outdated Show resolved Hide resolved
felix-russo and others added 2 commits August 15, 2023 16:08
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the enum should not go into the global acts namespace - otherwise looks good!

Examples/Python/src/Vertexing.cpp Outdated Show resolved Hide resolved
CI/physmon/workflows/physmon_track_finding_ttbar.py Outdated Show resolved Hide resolved
andiwand
andiwand previously approved these changes Aug 18, 2023
@kodiakhq kodiakhq bot merged commit 20cf882 into acts-project:main Aug 18, 2023
56 checks passed
@acts-project-service
Copy link
Collaborator

🔴 Athena integration test results

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Aug 18, 2023
kodiakhq bot pushed a commit that referenced this pull request Aug 21, 2023
Remove bug introduced in #2355, where updates in `phys_perf_mon.sh` were not correctly considered
@paulgessinger paulgessinger modified the milestones: next, v29.0.0 Aug 22, 2023
@paulgessinger
Copy link
Member

Build failure unrelated

@paulgessinger paulgessinger removed the Breaks Athena build This PR breaks the Athena build label Aug 29, 2023
@felix-russo felix-russo deleted the monitor-grid-seeding branch August 30, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes Performance Component - Core Affects the Core module Component - Examples Affects the Examples module Infrastructure Changes to build tools, continous integration, ... Vertexing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants