-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Exa.TrkX boost track building & unit test #2361
Merged
benjaminhuth
merged 12 commits into
acts-project:main
from
benjaminhuth:refactor/exatrkx-boost-track-building
Aug 17, 2023
Merged
refactor: Exa.TrkX boost track building & unit test #2361
benjaminhuth
merged 12 commits into
acts-project:main
from
benjaminhuth:refactor/exatrkx-boost-track-building
Aug 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or/exatrkx-boost-track-building
Codecov Report
@@ Coverage Diff @@
## main #2361 +/- ##
=======================================
Coverage 49.57% 49.57%
=======================================
Files 453 453
Lines 25514 25514
Branches 11707 11707
=======================================
Hits 12649 12649
Misses 4580 4580
Partials 8285 8285 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊: Physics performance monitoring for 57114b2physmon summary
|
benjaminhuth
changed the title
refactor: Exa.TrkX boost track building
refactor: Exa.TrkX boost track building & unit test
Aug 17, 2023
andiwand
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
acts-project-service
added
the
Fails Athena tests
This PR causes a failure in the Athena tests
label
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component - Plugins
Affects one or more Plugins
Fails Athena tests
This PR causes a failure in the Athena tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boost::beast::span
instead ofstd::vector
to avoid copies.Should go in after #2373