Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Exa.TrkX boost track building & unit test #2361

Conversation

benjaminhuth
Copy link
Member

@benjaminhuth benjaminhuth commented Aug 13, 2023

  • Use boost::beast::span instead of std::vector to avoid copies.
  • Improve labeling algorithm

Should go in after #2373

@github-actions github-actions bot added the Component - Plugins Affects one or more Plugins label Aug 13, 2023
@benjaminhuth benjaminhuth added this to the next milestone Aug 13, 2023
@benjaminhuth benjaminhuth marked this pull request as draft August 13, 2023 12:09
@codecov
Copy link

codecov bot commented Aug 13, 2023

Codecov Report

Merging #2361 (57114b2) into main (dd8188a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2361   +/-   ##
=======================================
  Coverage   49.57%   49.57%           
=======================================
  Files         453      453           
  Lines       25514    25514           
  Branches    11707    11707           
=======================================
  Hits        12649    12649           
  Misses       4580     4580           
  Partials     8285     8285           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@benjaminhuth benjaminhuth added the 🛑 blocked This item is blocked by another item label Aug 13, 2023
@benjaminhuth benjaminhuth changed the title refactor: Exa.TrkX boost track building refactor: Exa.TrkX boost track building & unit test Aug 17, 2023
@benjaminhuth benjaminhuth marked this pull request as ready for review August 17, 2023 07:07
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@andiwand andiwand removed the 🛑 blocked This item is blocked by another item label Aug 17, 2023
@benjaminhuth benjaminhuth merged commit 0eb5954 into acts-project:main Aug 17, 2023
56 checks passed
@benjaminhuth benjaminhuth deleted the refactor/exatrkx-boost-track-building branch August 17, 2023 11:45
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Aug 17, 2023
@paulgessinger paulgessinger modified the milestones: next, v28.2.0 Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Plugins Affects one or more Plugins Fails Athena tests This PR causes a failure in the Athena tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants