fix: Reset navigation state correctly in KF reverse pass #2368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2368 +/- ##
=======================================
Coverage 49.57% 49.57%
=======================================
Files 453 453
Lines 25514 25514
Branches 11707 11707
=======================================
Hits 12649 12649
Misses 4580 4580
Partials 8285 8285
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊: Physics performance monitoring for 92eb584physmon summary
|
benjaminhuth
previously approved these changes
Aug 17, 2023
benjaminhuth
approved these changes
Aug 17, 2023
acts-project-service
added
the
Fails Athena tests
andiwand
added a commit
that referenced
this pull request
Sep 22, 2023
Currently our intersection call can give an alternative solution but it is not clear which one is to be preferred in which situation and the results are unstable meaning that it could be swapped depending on where you are on the ray. Here I try to make the interface cleaner and the intersection order stable. blocked by - #2366 - #2368 --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: Benjamin Huth <37871400+benjaminhuth@users.noreply.github.com> Co-authored-by: Benjamin Huth <benjamin.huth@physik.uni-regensburg.de> Co-authored-by: Paul Gessinger <hello@paulgessinger.com>
AJPfleger
pushed a commit
to AJPfleger/acts
that referenced
this pull request
Sep 29, 2023
…2336) Currently our intersection call can give an alternative solution but it is not clear which one is to be preferred in which situation and the results are unstable meaning that it could be swapped depending on where you are on the ray. Here I try to make the interface cleaner and the intersection order stable. blocked by - acts-project#2366 - acts-project#2368 --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: Benjamin Huth <37871400+benjaminhuth@users.noreply.github.com> Co-authored-by: Benjamin Huth <benjamin.huth@physik.uni-regensburg.de> Co-authored-by: Paul Gessinger <hello@paulgessinger.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use a different abort mechanism in the KF and do not need to tell the navigator about the target surface
Pulled this out of #2336 where it fixed a bug