Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move some implementation from header to source #2371

Merged
merged 3 commits into from
Aug 16, 2023

Conversation

benjaminhuth
Copy link
Member

This caused linker errors when using a installed version of Acts...

@benjaminhuth benjaminhuth added this to the next milestone Aug 15, 2023
Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uncontroversial

@github-actions github-actions bot added the Component - Plugins Affects one or more Plugins label Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #2371 (3ddf7ba) into main (c83f8fc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2371   +/-   ##
=======================================
  Coverage   49.57%   49.57%           
=======================================
  Files         453      453           
  Lines       25513    25513           
  Branches    11707    11707           
=======================================
  Hits        12649    12649           
  Misses       4579     4579           
  Partials     8285     8285           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kodiakhq kodiakhq bot merged commit 543bd5a into acts-project:main Aug 16, 2023
56 checks passed
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Aug 16, 2023
@paulgessinger paulgessinger modified the milestones: next, v28.2.0 Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Plugins Affects one or more Plugins Fails Athena tests This PR causes a failure in the Athena tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants