refactor: Pre-calculated constant for convertLandauFwhmToGaussianSigma
#2372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
Codecov Report
@@ Coverage Diff @@
## main #2372 +/- ##
=======================================
Coverage 49.58% 49.58%
=======================================
Files 453 453
Lines 25517 25517
Branches 11706 11706
=======================================
Hits 12653 12653
Misses 4581 4581
Partials 8283 8283
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊: Physics performance monitoring for 17bb728physmon summary
|
github-actions
bot
removed
Infrastructure
|
Any idea why we reconstruct less vertices now? |
|
not sure if we do - the plot is hard to read these changes should not affect the AMVF results but do for unknown reasons. this is what I experienced a couple of times already. small changes in the sim or track fitting result in big changes in the AMVF hist cmp I updated the reference because the problem seems unrelated |
github-actions
bot
added
Infrastructure
github-actions
bot
removed
the
Infrastructure
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 17, 2023
AMVF vertex finding dropped vertex candidates because `isMergedVertex` would return `true` for negative covariance matrices. The reason why these matrices are negative definite is still unclear but we should not consider them as merged vertices by default I think. This was the reason why we experienced noisy AMVF physmon diff for mostly unrelated changes because these conditions would flip flop on small numerical changes. A small reproducible example can be found in #2372
benjaminhuth
previously approved these changes
Aug 17, 2023
benjaminhuth
added
automerge
and removed
🛑 blocked
|
physmon and the examples tests still seem to fail. |
|
oh no... the hash changes are expected but I would have thought the AMVF diff should be gone by now 😞 |
|
Really weird... An alternative would be a |
|
I am trying to find the problem in the AMVF which is causing this flip flop of vertices for small numerical changes. This diff here is quite nice to be able to find the spot |
benjaminhuth
approved these changes
Aug 21, 2023
acts-project-service
added
the
Fails Athena tests
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 21, 2023
…pes (#2366) Refactors the interactions interface to be minimal. That means only passing absolute charge and absolute PDG and only where necessary. At the same time I made the types explicit. For some reason we use `float` all across the interaction code which I kept and made more explicit. also fixes a weird FPE discovered in - #2336 pulled these changes out of - #2341 - #2336 blocked by - #2375 - #2372
|
Athena changes did not come from this PR. |
paulgessinger
removed
the
Fails Athena tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled out of #2366 to pin down the hash and physmon diff
blocked by