Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Configurable and more flexible binning for CKFPerformanceWriter #2379

Merged

Conversation

benjaminhuth
Copy link
Member

This allows for a more flexible binning for the PlotTools, and exposes this to python. For example, a binning can be configured like this:

binningCfg = {
    "Pt" : acts.examples.Binning("pT", list(np.logspace(-2,2,40))),
    "Eta" : acts.examples.Binning("eta", 40, -4, 4),
    "Phi" : acts.examples.Binning("phi", 100, -3.15, 3.15),
}

s.addWriter(
    acts.examples.CKFPerformanceWriter(
		...
        effPlotToolConfig = acts.examples.EffPlotToolConfig(self.binningCfg),
    )
)

@benjaminhuth benjaminhuth added this to the next milestone Aug 17, 2023
@benjaminhuth benjaminhuth marked this pull request as draft August 17, 2023 12:59
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Aug 17, 2023
@benjaminhuth benjaminhuth marked this pull request as ready for review August 17, 2023 13:03
andiwand
andiwand previously approved these changes Aug 17, 2023
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

andiwand
andiwand previously approved these changes Aug 17, 2023
andiwand
andiwand previously approved these changes Aug 17, 2023
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #2379 (9c7f96a) into main (e529c52) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2379   +/-   ##
=======================================
  Coverage   49.59%   49.59%           
=======================================
  Files         453      453           
  Lines       25694    25694           
  Branches    11808    11808           
=======================================
  Hits        12744    12744           
  Misses       4572     4572           
  Partials     8378     8378           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@paulgessinger
Copy link
Member

This has physmon failures.

@benjaminhuth benjaminhuth marked this pull request as draft August 28, 2023 09:13
@benjaminhuth benjaminhuth added the 🚧 WIP Work-in-progress label Aug 28, 2023
@benjaminhuth benjaminhuth removed the 🚧 WIP Work-in-progress label Aug 28, 2023
@benjaminhuth benjaminhuth marked this pull request as ready for review August 28, 2023 13:33
Examples/Python/src/Output.cpp Outdated Show resolved Hide resolved
Examples/Framework/src/Validation/ResPlotTool.cpp Outdated Show resolved Hide resolved
Examples/Framework/src/Utilities/Helpers.cpp Outdated Show resolved Hide resolved
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
@kodiakhq kodiakhq bot merged commit 3e77d7d into acts-project:main Aug 29, 2023
56 checks passed
@paulgessinger paulgessinger modified the milestones: next, v29.1.0 Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants