Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve CKF logging in examples #2389

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

andiwand
Copy link
Contributor

We used not to add loggers for the navigator and propagator in the examples CKF. This PR is adopting that

@andiwand andiwand added this to the next milestone Aug 22, 2023
@github-actions github-actions bot added Component - Examples Affects the Examples module Track Finding labels Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #2389 (cca93cb) into main (f652647) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2389   +/-   ##
=======================================
  Coverage   49.70%   49.70%           
=======================================
  Files         452      452           
  Lines       25468    25468           
  Branches    11651    11651           
=======================================
  Hits        12658    12658           
  Misses       4578     4578           
  Partials     8232     8232           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kodiakhq kodiakhq bot merged commit 555243e into acts-project:main Aug 23, 2023
55 checks passed
@andiwand andiwand deleted the exaples-improve-ckf-logging branch August 23, 2023 13:33
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Aug 23, 2023
@paulgessinger paulgessinger modified the milestones: next, v29.0.0 Aug 25, 2023
@paulgessinger
Copy link
Member

Unrelated failure.

@paulgessinger paulgessinger removed the Fails Athena tests This PR causes a failure in the Athena tests label Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module Track Finding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants