Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove ParticleStopped aborter #2398

Merged
merged 3 commits into from
Aug 25, 2023

Conversation

andiwand
Copy link
Contributor

qOverP will be undefined in the first place

Pulled out of #2341

@andiwand andiwand added this to the next milestone Aug 25, 2023
@github-actions github-actions bot added the Component - Core Affects the Core module label Aug 25, 2023
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #2398 (d6ddfe0) into main (bcf2ff9) will decrease coverage by 0.02%.
Report is 2 commits behind head on main.
The diff coverage is 30.00%.

@@            Coverage Diff             @@
##             main    #2398      +/-   ##
==========================================
- Coverage   49.54%   49.52%   -0.02%     
==========================================
  Files         453      453              
  Lines       25679    25686       +7     
  Branches    11811    11818       +7     
==========================================
- Hits        12722    12721       -1     
  Misses       4583     4583              
- Partials     8374     8382       +8     
Files Changed Coverage Δ
Core/include/Acts/Propagator/StandardAborters.hpp 71.73% <ø> (+3.11%) ⬆️
...ude/Acts/SpacePointFormation/SpacePointBuilder.hpp 50.00% <ø> (ø)
...ts/SpacePointFormation/SpacePointBuilderConfig.hpp 100.00% <ø> (ø)
...de/Acts/TrackFinding/CombinatorialKalmanFilter.hpp 31.86% <ø> (ø)
...re/include/Acts/TrackFitting/GaussianSumFitter.hpp 43.91% <0.00%> (-0.68%) ⬇️
...nclude/Acts/TrackFitting/GlobalChiSquareFitter.hpp 38.65% <0.00%> (-0.62%) ⬇️
Core/include/Acts/TrackFitting/GsfOptions.hpp 100.00% <ø> (ø)
.../Acts/TrackFitting/detail/VoidKalmanComponents.hpp 26.66% <ø> (ø)
Core/include/Acts/Utilities/SpacePointUtility.hpp 100.00% <ø> (ø)
.../include/Acts/Vertexing/HelicalTrackLinearizer.hpp 100.00% <ø> (ø)
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@benjaminhuth benjaminhuth modified the milestones: next, v29.0.0 Aug 25, 2023
Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there seem to be no changes in the output, looks fine to me!

@kodiakhq kodiakhq bot merged commit 32e0119 into acts-project:main Aug 25, 2023
56 checks passed
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Aug 25, 2023
@andiwand andiwand deleted the remove-particle-stopped-aborter branch August 26, 2023 08:38
@paulgessinger paulgessinger removed the Fails Athena tests This PR causes a failure in the Athena tests label Aug 29, 2023
@paulgessinger
Copy link
Member

Unrelated failure.

kodiakhq bot pushed a commit that referenced this pull request Sep 18, 2023
In this PR I make the particle hypothesis part of the track parameters. This allows us to consistently use the same hypothesis across various parts of our code. Before that the particle hypothesis was a bit scattered in the propagator and stepper.

replaces #2181 after splitting it up

blocked by
- #2366
- #2396
- #2398
- #2397
AJPfleger pushed a commit to AJPfleger/acts that referenced this pull request Sep 29, 2023
In this PR I make the particle hypothesis part of the track parameters. This allows us to consistently use the same hypothesis across various parts of our code. Before that the particle hypothesis was a bit scattered in the propagator and stepper.

replaces acts-project#2181 after splitting it up

blocked by
- acts-project#2366
- acts-project#2396
- acts-project#2398
- acts-project#2397
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Track Finding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants