-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Remove ParticleStopped
aborter
#2398
refactor: Remove ParticleStopped
aborter
#2398
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2398 +/- ##
==========================================
- Coverage 49.54% 49.52% -0.02%
==========================================
Files 453 453
Lines 25679 25686 +7
Branches 11811 11818 +7
==========================================
- Hits 12722 12721 -1
Misses 4583 4583
- Partials 8374 8382 +8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there seem to be no changes in the output, looks fine to me!
Unrelated failure. |
In this PR I make the particle hypothesis part of the track parameters. This allows us to consistently use the same hypothesis across various parts of our code. Before that the particle hypothesis was a bit scattered in the propagator and stepper. replaces #2181 after splitting it up blocked by - #2366 - #2396 - #2398 - #2397
In this PR I make the particle hypothesis part of the track parameters. This allows us to consistently use the same hypothesis across various parts of our code. Before that the particle hypothesis was a bit scattered in the propagator and stepper. replaces acts-project#2181 after splitting it up blocked by - acts-project#2366 - acts-project#2396 - acts-project#2398 - acts-project#2397
qOverP
will be undefined in the first placePulled out of #2341