ci: Update LCG tests #2410
Merged
ci: Update LCG tests #2410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This showed up in our GCC12 based LCG builds, and only in Release mode. I don't think there's a way for us to fix this because the warning actually comes from `std::move`'ing `boost::small_vectors`. I'm suppressing the warnings here and remove the job from being allowed to fail.
Codecov Report
@@ Coverage Diff @@
## main #2410 +/- ##
=======================================
Coverage 49.82% 49.82%
=======================================
Files 466 466
Lines 26246 26247 +1
Branches 12050 12050
=======================================
+ Hits 13077 13078 +1
Misses 4603 4603
Partials 8566 8566
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Ok:
|
github-actions
bot
added
Component - Core
github-actions
bot
added
Component - Plugins
andiwand
approved these changes
Sep 28, 2023
AJPfleger
pushed a commit
to AJPfleger/acts
that referenced
this pull request
Sep 29, 2023
Removes the forces assertions from the LCG builds, because I've observed these to fail in clang15 on LCG 103. I don't think we necessarily need to have these turned on, and we know this is a hack anyway. This PR then also includes builds for LCG104, and switches the LCG102 build over to LCG102b_ATLAS_23 (which is what Athena currently builds on) Blocked by: - acts-project#2407
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the forces assertions from the LCG builds, because I've observed these to fail in clang15 on LCG 103.
I don't think we necessarily need to have these turned on, and we know this is a hack anyway.
This PR then also includes builds for LCG104, and switches the LCG102 build over to LCG102b_ATLAS_23 (which is what Athena currently builds on)
Blocked by: