-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Propagator deduce parameter type from stepper #2413
refactor: Propagator deduce parameter type from stepper #2413
Conversation
@andiwand @paulgessinger Let me know what you think about the change. I think this is NOT breaking, because for all non-GSF code the acutal types involved don't change, and the GSF is still in If preffered, I could split of the part with the optional covariance... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable
Codecov Report
@@ Coverage Diff @@
## main #2413 +/- ##
==========================================
+ Coverage 49.82% 49.84% +0.02%
==========================================
Files 468 468
Lines 26539 26524 -15
Branches 12197 12187 -10
==========================================
- Hits 13224 13222 -2
- Misses 4632 4634 +2
+ Partials 8683 8668 -15
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
What's the plan for this @benjaminhuth? |
Hmm I resolved the merge conflicts. If physmon is green I think I would propose to merge it |
This PR currently has a merge conflict. Please resolve this and then re-add the |
The main change is that the
Acts::Propagator
now deduces the parameters type (bound and curvilinear) from the stepper.This allows the
MultiStepper
to return multi-component-parameters, and makes the whole structure of the GSF more straight.Related changes to GSF infrastructure: