Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Root simhit reader event range #2430

Merged

Conversation

benjaminhuth
Copy link
Member

I think in my last refactor of this, I introduced a bug, the reader reported the wrong event range. This fixes it.

@benjaminhuth benjaminhuth added this to the next milestone Sep 6, 2023
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Sep 6, 2023
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #2430 (6c12b7e) into main (acc222e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2430   +/-   ##
=======================================
  Coverage   49.67%   49.67%           
=======================================
  Files         455      455           
  Lines       25820    25820           
  Branches    11855    11855           
=======================================
  Hits        12825    12825           
  Misses       4592     4592           
  Partials     8403     8403           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kodiakhq kodiakhq bot merged commit e1fbe73 into acts-project:main Sep 6, 2023
57 checks passed
@github-actions github-actions bot removed the automerge label Sep 6, 2023
@paulgessinger paulgessinger modified the milestones: next, v29.1.0 Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants