Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add optional pass through of prototracks to param estimation algorithm #2438

Merged

Conversation

benjaminhuth
Copy link
Member

@benjaminhuth benjaminhuth commented Sep 11, 2023

In the case the param estimation fails, the number of parameters/seeds/prototracks does not match, which makes e.g., downstream track fitting impossible.
This allows to pass-through a prototrack collection through the algorithm, in order to ensure they match always.

@benjaminhuth benjaminhuth added this to the next milestone Sep 11, 2023
@github-actions github-actions bot added Component - Examples Affects the Examples module Track Finding labels Sep 11, 2023
@benjaminhuth benjaminhuth changed the title features: Add optional output seeds to param estimation algorithm feat: Add optional output seeds to param estimation algorithm Sep 11, 2023
@benjaminhuth benjaminhuth changed the title feat: Add optional output seeds to param estimation algorithm feat: Add optional pass through of prototracks to param estimation algorithm Sep 11, 2023
…rithm.cpp

Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #2438 (3e0e874) into main (3214740) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main    #2438   +/-   ##
=======================================
  Coverage   49.70%   49.70%           
=======================================
  Files         458      458           
  Lines       25946    25949    +3     
  Branches    11918    11919    +1     
=======================================
+ Hits        12896    12899    +3     
- Misses       4595     4596    +1     
+ Partials     8455     8454    -1     
Files Changed Coverage Δ
...clude/Acts/Detector/detail/ReferenceGenerators.hpp 46.66% <0.00%> (+2.91%) ⬆️
Core/include/Acts/Detector/KdtSurfacesProvider.hpp 60.86% <56.25%> (+3.36%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kodiakhq kodiakhq bot merged commit af4ad67 into acts-project:main Sep 12, 2023
58 checks passed
kodiakhq bot pushed a commit that referenced this pull request Sep 13, 2023
@paulgessinger paulgessinger modified the milestones: next, v29.2.0 Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module Track Finding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants