-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add optional pass through of prototracks to param estimation algorithm #2438
Merged
kodiakhq
merged 6 commits into
acts-project:main
from
benjaminhuth:feature/param-estimation-output-seeds
Sep 12, 2023
Merged
feat: Add optional pass through of prototracks to param estimation algorithm #2438
kodiakhq
merged 6 commits into
acts-project:main
from
benjaminhuth:feature/param-estimation-output-seeds
Sep 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Examples
Affects the Examples module
Track Finding
labels
Sep 11, 2023
benjaminhuth
changed the title
features: Add optional output seeds to param estimation algorithm
feat: Add optional output seeds to param estimation algorithm
Sep 11, 2023
andiwand
reviewed
Sep 11, 2023
Examples/Algorithms/TrackFinding/src/TrackParamsEstimationAlgorithm.cpp
Outdated
Show resolved
Hide resolved
benjaminhuth
changed the title
feat: Add optional output seeds to param estimation algorithm
feat: Add optional pass through of prototracks to param estimation algorithm
Sep 11, 2023
…rithm.cpp Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
andiwand
reviewed
Sep 11, 2023
andiwand
approved these changes
Sep 11, 2023
Codecov Report
@@ Coverage Diff @@
## main #2438 +/- ##
=======================================
Coverage 49.70% 49.70%
=======================================
Files 458 458
Lines 25946 25949 +3
Branches 11918 11919 +1
=======================================
+ Hits 12896 12899 +3
- Misses 4595 4596 +1
+ Partials 8455 8454 -1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 13, 2023
Fix some errors introduced in #2438
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case the param estimation fails, the number of parameters/seeds/prototracks does not match, which makes e.g., downstream track fitting impossible.
This allows to pass-through a prototrack collection through the algorithm, in order to ensure they match always.