refactor: Optional curvilinear state in Propagator #2444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far, without a target surface, the propagator unconditionally produces curvilinear parameters, and allocates a plane surface for this. This adds an argument, which if set to false tells the Propagator not to do that. In particular, we don't use this curvilinear state at all in the CKF and KF (I'm not sure about the GSF).
github-actions
bot
added
Component - Core
It isn't used in the GSF either. Rather, the requirement to provide this functionality is a bit annoying (but it should be there I guess) |
Codecov Report
@@ Coverage Diff @@
## main #2444 +/- ##
==========================================
- Coverage 49.71% 49.70% -0.01%
==========================================
Files 461 461
Lines 25989 25990 +1
Branches 11934 11935 +1
==========================================
- Hits 12921 12919 -2
- Misses 4600 4602 +2
- Partials 8468 8469 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, without a target surface, the propagator unconditionally produces curvilinear parameters, and allocates a plane surface for this. This adds an argument, which if set to false tells the Propagator not to do that. In particular, we don't use this curvilinear state at all in the CKF and KF (I'm not sure about the GSF).