-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Remove GSF meta cache #2448
Merged
kodiakhq
merged 10 commits into
acts-project:main
from
benjaminhuth:refactor/try-remove-gsf-meta-cache
Sep 18, 2023
Merged
refactor: Remove GSF meta cache #2448
kodiakhq
merged 10 commits into
acts-project:main
from
benjaminhuth:refactor/try-remove-gsf-meta-cache
Sep 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2448 +/- ##
=======================================
Coverage 49.70% 49.71%
=======================================
Files 461 461
Lines 25989 25981 -8
Branches 11934 11929 -5
=======================================
- Hits 12919 12916 -3
Misses 4602 4602
+ Partials 8468 8463 -5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
github-actions
bot
added
Component - Examples
Affects the Examples module
Changes Performance
labels
Sep 14, 2023
benjaminhuth
changed the title
refactor: try to remove GSF meta cache
refactor: Remove GSF meta cache
Sep 18, 2023
andiwand
previously approved these changes
Sep 18, 2023
andiwand
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changes Performance
Component - Core
Affects the Core module
Component - Examples
Affects the Examples module
Track Fitting
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The meta cache is a remainder of an older version and not necessary in the current implementation.
No changes in the
tracksummary_gsf.root
as expected. Difference intrackstates_gsf.root
hashes should come from the pathlength entries, which is accumulated different now.