Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove GSF meta cache #2448

Merged

Conversation

benjaminhuth
Copy link
Member

@benjaminhuth benjaminhuth commented Sep 14, 2023

The meta cache is a remainder of an older version and not necessary in the current implementation.

No changes in the tracksummary_gsf.root as expected. Difference in trackstates_gsf.root hashes should come from the pathlength entries, which is accumulated different now.

@benjaminhuth benjaminhuth added the 🚧 WIP Work-in-progress label Sep 14, 2023
@benjaminhuth benjaminhuth added this to the next milestone Sep 14, 2023
@github-actions github-actions bot added Component - Core Affects the Core module Track Fitting labels Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #2448 (6a5e50f) into main (8071832) will increase coverage by 0.00%.
The diff coverage is 22.22%.

@@           Coverage Diff           @@
##             main    #2448   +/-   ##
=======================================
  Coverage   49.70%   49.71%           
=======================================
  Files         461      461           
  Lines       25989    25981    -8     
  Branches    11934    11929    -5     
=======================================
- Hits        12919    12916    -3     
  Misses       4602     4602           
+ Partials     8468     8463    -5     
Files Changed Coverage Δ
Core/include/Acts/TrackFitting/detail/GsfActor.hpp 45.51% <22.22%> (+0.20%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@benjaminhuth benjaminhuth changed the title refactor: try to remove GSF meta cache refactor: Remove GSF meta cache Sep 18, 2023
@benjaminhuth benjaminhuth marked this pull request as ready for review September 18, 2023 06:54
andiwand
andiwand previously approved these changes Sep 18, 2023
Core/include/Acts/TrackFitting/detail/GsfActor.hpp Outdated Show resolved Hide resolved
@paulgessinger paulgessinger removed the 🚧 WIP Work-in-progress label Sep 18, 2023
@kodiakhq kodiakhq bot merged commit 67be87d into acts-project:main Sep 18, 2023
59 checks passed
@paulgessinger paulgessinger modified the milestones: next, v30.0.0 Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants