Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Kalman filter smoother logging #2468

Merged
merged 3 commits into from
Sep 21, 2023

Conversation

andiwand
Copy link
Contributor

We are printing the wrong quantities in GainMatrixSmoother. Here I correct this

@andiwand andiwand added this to the next milestone Sep 20, 2023
@github-actions github-actions bot added Component - Core Affects the Core module Track Fitting labels Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #2468 (b3870f9) into main (8796478) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #2468   +/-   ##
=======================================
  Coverage   49.80%   49.80%           
=======================================
  Files         466      466           
  Lines       26141    26141           
  Branches    11989    11989           
=======================================
  Hits        13019    13019           
  Misses       4615     4615           
  Partials     8507     8507           
Files Changed Coverage Δ
...e/include/Acts/TrackFitting/GainMatrixSmoother.hpp 52.08% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kodiakhq kodiakhq bot merged commit 5cdea63 into acts-project:main Sep 21, 2023
57 checks passed
@andiwand andiwand deleted the fix-kf-logging branch September 21, 2023 09:02
@paulgessinger paulgessinger modified the milestones: next, v30.0.0 Sep 21, 2023
AJPfleger pushed a commit to AJPfleger/acts that referenced this pull request Sep 29, 2023
We are printing the wrong quantities in `GainMatrixSmoother`. Here I correct this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Track Fitting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants