feat: Add angles of incidence in RootMeasurementWriter

[gagnonlg]

For measurement calibrations, the angles of incidence on a surface are very useful. Previously, the MeasurementReader only saved the truth particle direction in the global frame, so this PR adds the angle of incidence.

To validate, here are the angles of incidence for 1-pixel clusters on the Generic detector barrel:

(presumably, the phi distribution is asymetric because of the Lorentz angle)

closes #2484

[codecov]

Codecov Report

Merging #2493 (294140f) into main (363d111) will decrease coverage by 0.01%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main    #2493      +/-   ##
==========================================
- Coverage   49.81%   49.81%   -0.01%     
==========================================
  Files         466      466              
  Lines       26248    26253       +5     
  Branches    12051    12054       +3     
==========================================
+ Hits        13075    13077       +2     
  Misses       4606     4606              
- Partials     8567     8570       +3     

Files	Coverage Δ
Core/include/Acts/Utilities/VectorHelpers.hpp	87.14% <40.00%> (-3.63%)	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[github-actions]

📊: Physics performance monitoring for 294140f

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Particles inital fatras
• ✅ Particles final fatras
• ✅ Particles inital geant4
• ✅ Particles final geant4

[acts-project-service]

🔴 Athena integration test results

Build job with this PR failed!

Please investigate the build job for the pipeline!

[gagnonlg]

The Athena build failure in question:

/builds/acts/acts-athena-ci/athena/Tracking/Acts/ActsVertexReconstruction/src/IterativePriVtxFinderTool.cxx: In member function 'virtual StatusCode ActsTrk::IterativePriVtxFinderTool::initialize()':
/builds/acts/acts-athena-ci/athena/Tracking/Acts/ActsVertexReconstruction/src/IterativePriVtxFinderTool.cxx:105:16: error: 'struct Acts::IterativeVertexFinder<Acts::FullBilloirVertexFitter<ActsTrk::IterativePriVtxFinderTool::TrackWrapper, Acts::HelicalTrackLinearizer<Acts::Propagator<Acts::EigenStepper<>, Acts::Navigator> > >, Acts::TrackDensityVertexFinder<Acts::FullBilloirVertexFitter<ActsTrk::IterativePriVtxFinderTool::TrackWrapper, Acts::HelicalTrackLinearizer<Acts::Propagator<Acts::EigenStepper<>, Acts::Navigator> > >, Acts::GaussianTrackDensity<ActsTrk::IterativePriVtxFinderTool::TrackWrapper> > >::Config' has no member named 'maximumChi2cutForSeeding'; did you mean 'maximumChi2CutForSeeding'?
  105 |   finderConfig.maximumChi2cutForSeeding = m_maximumChi2cutForSeeding;
      |                ^~~~~~~~~~~~~~~~~~~~~~~~
      |                maximumChi2CutForSeeding
      

Doesn't seem to be caused by this PR

[paulgessinger]

It's due to #2485, and should be fixed with #2495