Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fill track in GX2F #2511

Merged
merged 13 commits into from
Oct 20, 2023
Merged

Conversation

AJPfleger
Copy link
Contributor

@AJPfleger AJPfleger commented Oct 4, 2023

Next generalisation of the Global Chi Square Fitter (GX2F). Now it can fill a track with reasonable trackStates.

This will be followed by an PR including a python example (truth_tracking) to analyse the root-outputs.

Keep in mind, that some of the trackStates still might not be filled with the correct values.

@github-actions github-actions bot added Component - Core Affects the Core module Track Fitting labels Oct 4, 2023
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #2511 (361d1fd) into main (185d0da) will increase coverage by 0.00%.
The diff coverage is 35.18%.

@@           Coverage Diff           @@
##             main    #2511   +/-   ##
=======================================
  Coverage   49.82%   49.82%           
=======================================
  Files         468      468           
  Lines       26509    26539   +30     
  Branches    12180    12197   +17     
=======================================
+ Hits        13209    13224   +15     
+ Misses       4633     4632    -1     
- Partials     8667     8683   +16     
Files Coverage Δ
...nclude/Acts/TrackFitting/GlobalChiSquareFitter.hpp 41.08% <35.18%> (+1.55%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@felix-russo felix-russo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part 1: Only (very) nitpicky comments
I started a review but realized I have no idea what is going on ^^
I will pass by your office tomorrow before continuing...

Copy link
Contributor

@felix-russo felix-russo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me other than that, but I think a tracking expert should have another look at this

Core/include/Acts/TrackFitting/GlobalChiSquareFitter.hpp Outdated Show resolved Hide resolved
Core/include/Acts/TrackFitting/GlobalChiSquareFitter.hpp Outdated Show resolved Hide resolved
kodiakhq bot pushed a commit that referenced this pull request Oct 19, 2023
…2556)

We were discussing a bit (starting from #2511 ) if we can remove `effectiveProjector` from the collector in the GlobalChiSquareFitter, since it is not very efficient. This PR now removes it.
Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good!

Changes I suggest can be done in a follow-up PR imo, because it's still correct the way it's done right now.

@paulgessinger paulgessinger added this to the next milestone Oct 20, 2023
@kodiakhq kodiakhq bot merged commit a9ab6a5 into acts-project:main Oct 20, 2023
55 checks passed
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Oct 20, 2023
@AJPfleger AJPfleger deleted the gx2f-filltrackstates branch October 21, 2023 16:53
@paulgessinger paulgessinger modified the milestones: next, v30.3.0 Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Fails Athena tests This PR causes a failure in the Athena tests Track Fitting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants