Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add csv prototrack writer #2513

Merged

Conversation

benjaminhuth
Copy link
Member

This is useful when working e.g. with the Exa.TrkX plugin.

@benjaminhuth benjaminhuth added this to the next milestone Oct 5, 2023
andiwand
andiwand previously approved these changes Oct 5, 2023
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few minor suggestions but nothing critical

@github-actions github-actions bot added the Component - Examples Affects the Examples module label Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #2513 (3d16b4b) into main (cc7857b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2513   +/-   ##
=======================================
  Coverage   49.79%   49.79%           
=======================================
  Files         466      466           
  Lines       26326    26326           
  Branches    12095    12095           
=======================================
  Hits        13108    13108           
  Misses       4615     4615           
  Partials     8603     8603           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
andiwand
andiwand previously approved these changes Oct 5, 2023
@paulgessinger
Copy link
Member

This currently still fails the python tests and clang-tidy.

@kodiakhq kodiakhq bot merged commit 25331d0 into acts-project:main Oct 19, 2023
55 checks passed
@acts-project-service acts-project-service added Breaks Athena build This PR breaks the Athena build Fails Athena tests This PR causes a failure in the Athena tests labels Oct 19, 2023
@paulgessinger paulgessinger modified the milestones: next, v30.3.0 Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaks Athena build This PR breaks the Athena build Component - Examples Affects the Examples module Fails Athena tests This PR causes a failure in the Athena tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants