Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Refactor CKF error handling and introduce path limit #2540

Merged

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Oct 12, 2023

These changes make the path limit more sound in the CKF. Before we did not respect the path limit during target surface propagation which can result in propagation step overflow for loopers.

At the same time I tried to improve the error handling by not aborting the whole propagation in case of an error but keep going on until we handled all branches. This is not fully communicated downstream yet but will still result in error logs we can catch.

Pulled out of #2518

bocked by

@andiwand andiwand added this to the next milestone Oct 12, 2023
@github-actions github-actions bot added Component - Core Affects the Core module Track Finding labels Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #2540 (3bbeb5b) into main (69e2190) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 26.08%.

@@           Coverage Diff           @@
##             main    #2540   +/-   ##
=======================================
  Coverage   49.76%   49.77%           
=======================================
  Files         466      466           
  Lines       26323    26329    +6     
  Branches    12095    12100    +5     
=======================================
+ Hits        13100    13105    +5     
+ Misses       4624     4621    -3     
- Partials     8599     8603    +4     
Files Coverage Δ
...clude/Acts/Vertexing/AdaptiveMultiVertexFitter.ipp 43.87% <33.33%> (-0.21%) ⬇️
...de/Acts/TrackFinding/CombinatorialKalmanFilter.hpp 32.49% <25.00%> (+0.39%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andiwand andiwand added the 🛑 blocked This item is blocked by another item label Oct 13, 2023
@andiwand andiwand removed the 🛑 blocked This item is blocked by another item label Oct 16, 2023
@kodiakhq kodiakhq bot merged commit 6371455 into acts-project:main Oct 18, 2023
55 checks passed
@andiwand andiwand deleted the refactor-ckf-pathlimit-and-error-handling branch October 18, 2023 09:52
@paulgessinger paulgessinger modified the milestones: next, v30.3.0 Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Track Finding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants