fix: Add envelope to CuboidVolumeBuilder

[andiwand]

I noticed that the CuboidVolumeBuilder is not generating any envelope around the generated layer which results in overlapping surfaces which does not play nicely with navigation.

discovered in #2532

[codecov]

Codecov Report

Merging #2542 (053c906) into main (16e44c0) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 37.50%.

❗ Current head 053c906 differs from pull request most recent head 3cc6ac4. Consider uploading reports for the commit 3cc6ac4 to get more accurate results

@@            Coverage Diff             @@
##             main    #2542      +/-   ##
==========================================
- Coverage   49.77%   49.76%   -0.01%     
==========================================
  Files         466      466              
  Lines       26311    26318       +7     
  Branches    12093    12095       +2     
==========================================
+ Hits        13096    13097       +1     
- Misses       4616     4621       +5     
- Partials     8599     8600       +1     

Files	Coverage Δ
Core/src/Geometry/CuboidVolumeBuilder.cpp	42.53% <100.00%> (+1.31%)	⬆️
Core/src/Geometry/LayerCreator.cpp	23.07% <0.00%> (-0.43%)	⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[github-actions]

📊: Physics performance monitoring for 3cc6ac4

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ Track Summary CKF ttbar
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Particles inital fatras
• ✅ Particles final fatras
• ✅ Particles inital geant4
• ✅ Particles final geant4

[felix-russo]

Looks good, just one question for my understanding

.

[paulgessinger]

Actually, I just now remembered #1751. So shouldn't this in principle already be configurable (but not correctly configured)?

[andiwand]

Actually, I just now remembered #1751. So shouldn't this in principle already be configurable (but not correctly configured)?

right it is configurable but then we default it in the volume builder which results in 0 envelope again

[paulgessinger]

@andiwand Ah, and this is only if the cuboid builder auto-builds a single layer, without an explicit layer configuration.

[acts-project-service]

✅ Athena integration test results

✅ All tests successful

status	job
🟢	run_unit_tests
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data