-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Make Fatras Particle
and simulation surface aware
#2546
Merged
kodiakhq
merged 14 commits into
acts-project:main
from
andiwand:refactor-make-fatras-particle-surface-aware
Oct 25, 2023
Merged
refactor: Make Fatras Particle
and simulation surface aware
#2546
kodiakhq
merged 14 commits into
acts-project:main
from
andiwand:refactor-make-fatras-particle-surface-aware
Oct 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Fatras
Affects the Fatras module
Event Data Model
labels
Oct 16, 2023
github-actions
bot
added
the
Infrastructure
Changes to build tools, continous integration, ...
label
Oct 16, 2023
Codecov Report
@@ Coverage Diff @@
## main #2546 +/- ##
=======================================
Coverage 49.64% 49.64%
=======================================
Files 471 471
Lines 26632 26632
Branches 12237 12237
=======================================
Hits 13222 13222
Misses 4742 4742
Partials 8668 8668 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…e-fatras-particle-surface-aware
github-actions
bot
removed
the
Infrastructure
Changes to build tools, continous integration, ...
label
Oct 17, 2023
github-actions
bot
added
Infrastructure
Changes to build tools, continous integration, ...
Component - Examples
Affects the Examples module
Changes Performance
labels
Oct 24, 2023
benjaminhuth
previously approved these changes
Oct 24, 2023
benjaminhuth
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changes Performance
Component - Examples
Affects the Examples module
Component - Fatras
Affects the Fatras module
Event Data Model
Infrastructure
Changes to build tools, continous integration, ...
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently our Fatras simulation does not remember the surface particles were created on. This is a problem for the navigation as we cannot know if a close by surface was already encountered or not.
I propose to add a reference surface to the Fatras
Particle
which can be carried through in the propagation and then be used as a starting point for a new propagation.We will also have to decide if a photon conversion on a sensitive surface should result in a hit or not. But this should be done in a separate PR if possible.
blocked by