feat: introduce blueprint #2550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asalzburger
force-pushed
the
feat-introduce-blueprint
branch
from
f911f92
to
9157a81
Compare
|
Haven't looked at the code yet, but the visualization is hot stuff! 🔥 |
Codecov Report
@@ Coverage Diff @@
## main #2550 +/- ##
==========================================
+ Coverage 49.76% 49.81% +0.04%
==========================================
Files 466 468 +2
Lines 26353 26508 +155
Branches 12100 12182 +82
==========================================
+ Hits 13114 13204 +90
- Misses 4632 4633 +1
- Partials 8607 8671 +64
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
asalzburger
force-pushed
the
feat-introduce-blueprint
branch
from
2199646
to
3aaf202
Compare
asalzburger
force-pushed
the
feat-introduce-blueprint
branch
from
ed1ed89
to
8cdab66
Compare
acts-policybot
bot
dismissed
niermann999’s stale review
Invalidated by push of 90868d2
|
Hi @niermann999 @paulgessinger - I think I addressed all your comments now, please have a look if you're ok with the PR. |
niermann999
approved these changes
Oct 20, 2023
andiwand
pushed a commit
to andiwand/acts
that referenced
this pull request
Oct 20, 2023
This PR is the next attempt to introduce an instruction tree for detector building, this is a follow-up of discussion with @paulgessinger and is meant as a replacement / alternative solution to acts-project#2537. For this PR - instead of proxies - the simple construction tree is created, momentarily for cylindrical detectors. This allows the building process to be displayed as a graph:  **A Helper (currently for cylindrical detectors only** It then allows also for sorting the nodes in "R" and "Z": - before sorting:  - after sorting:  It also allows to insert gap nodes: - before inserting:  - after inserting:  In a follow-up PR it will be shown how to work with the `CylindricalContainerBuilder` schema and eventually a DD4hep test.
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 25, 2023
This PR follows #2550 and introduces an automated conversion from blueprint to a cylindrical detector builder. - it adds the auto-translation of blueprint to cylindrical container builder - plus unit test (yes, it's boiler plate blueprint building, but the code for detector building is now really concise) - it adds the graphical representation of `root volume finder builder` and `geo id generator`: <img width="750" alt="Screenshot 2023-10-20 at 16 55 51" src="https://github.com/acts-project/acts/assets/26623879/5ee546db-9581-47be-82fe-32212a08cb9b">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the next attempt to introduce an instruction tree for detector building, this is a follow-up of discussion with @paulgessinger and is meant as a replacement / alternative solution to #2537. For this PR - instead of proxies - the simple construction tree is created, momentarily for cylindrical detectors.
This allows the building process to be displayed as a graph:
A Helper (currently for cylindrical detectors only
It then allows also for sorting the nodes in "R" and "Z":
before sorting:
after sorting:
It also allows to insert gap nodes:
before inserting:
after inserting:
In a follow-up PR it will be shown how to work with the
CylindricalContainerBuilderschema and eventually a DD4hep test.