Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove division of vertex covariance with weight #2551

Merged
merged 10 commits into from
Oct 25, 2023

Conversation

felix-russo
Copy link
Contributor

Reopen #2522 which we had to revert due to athena output changes
Should go in for the next major version

@github-actions github-actions bot added Component - Core Affects the Core module Vertexing labels Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #2551 (d4af6a6) into main (e0d26d8) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2551   +/-   ##
=======================================
  Coverage   49.60%   49.61%           
=======================================
  Files         471      471           
  Lines       26695    26693    -2     
  Branches    12284    12282    -2     
=======================================
+ Hits        13242    13243    +1     
  Misses       4747     4747           
+ Partials     8706     8703    -3     
Files Coverage Δ
...clude/Acts/Vertexing/AdaptiveMultiVertexFitter.ipp 42.48% <ø> (+1.19%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@paulgessinger paulgessinger added this to the v31.0.0 milestone Oct 18, 2023
@paulgessinger paulgessinger changed the title refactor: remove division of vertex covariance with weight refactor!: remove division of vertex covariance with weight Oct 23, 2023
andiwand
andiwand previously approved these changes Oct 23, 2023
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Oct 25, 2023
@kodiakhq kodiakhq bot merged commit 8ce9fd3 into acts-project:main Oct 25, 2023
54 checks passed
@felix-russo felix-russo deleted the remove-vtx-weight branch November 6, 2023 18:20
@paulgessinger paulgessinger added Breaks Athena build This PR breaks the Athena build Fails Athena tests This PR causes a failure in the Athena tests and removed Fails Athena tests This PR causes a failure in the Athena tests labels Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaks Athena build This PR breaks the Athena build Component - Core Affects the Core module Fails Athena tests This PR causes a failure in the Athena tests Vertexing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants