Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add timing, device hint and mutex to ExaTrkX plugin #2553

Merged

Conversation

benjaminhuth
Copy link
Member

Some new small features for Exa.TrkX plugin and algorithm

  • Allow to measure timing
  • add a device hint to select GPU device
  • Add mutex to run save in MT environments

@benjaminhuth benjaminhuth added this to the next milestone Oct 18, 2023
@github-actions github-actions bot added Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Track Finding labels Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #2553 (bec217f) into main (35ec532) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head bec217f differs from pull request most recent head 93bef43. Consider uploading reports for the commit 93bef43 to get more accurate results

@@           Coverage Diff           @@
##             main    #2553   +/-   ##
=======================================
  Coverage   49.79%   49.79%           
=======================================
  Files         466      466           
  Lines       26326    26326           
  Branches    12095    12095           
=======================================
  Hits        13108    13108           
  Misses       4615     4615           
  Partials     8603     8603           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
andiwand
andiwand previously approved these changes Oct 18, 2023
@andiwand
Copy link
Contributor

@benjaminhuth can you update the formatting?

@kodiakhq kodiakhq bot merged commit cc7857b into acts-project:main Oct 19, 2023
54 checks passed
@acts-project-service
Copy link
Collaborator

acts-project-service commented Oct 19, 2023

🔴 Athena integration test results

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added Fails Athena tests This PR causes a failure in the Athena tests Breaks Athena build This PR breaks the Athena build labels Oct 19, 2023
@paulgessinger paulgessinger modified the milestones: next, v30.3.0 Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaks Athena build This PR breaks the Athena build Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Fails Athena tests This PR causes a failure in the Athena tests Track Finding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants