-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use blueprint to generate cylindrical detector #2557
feat: use blueprint to generate cylindrical detector #2557
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2557 +/- ##
==========================================
- Coverage 49.64% 49.63% -0.02%
==========================================
Files 471 471
Lines 26632 26679 +47
Branches 12237 12270 +33
==========================================
+ Hits 13222 13242 +20
- Misses 4742 4743 +1
- Partials 8668 8694 +26
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Tests/UnitTests/Core/Detector/CylindricalDetectorFromBlueprintTests.cpp
Outdated
Show resolved
Hide resolved
Tests/UnitTests/Core/Detector/CylindricalDetectorFromBlueprintTests.cpp
Outdated
Show resolved
Hide resolved
284f75d
to
6b8dfe0
Compare
Hoi @paulgessinger - I addressed all your comments, I suppose, do you think this could be merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
If you don't mind I'll have a quick look in a minute. EDIT: Thank! Let's go! |
Re-triggered pipelines due to CI failures. |
This PR follows #2550 and introduces an automated conversion from blueprint to a cylindrical detector builder.
root volume finder builder
andgeo id generator
: