-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Set Current Surface as first surface for direct navigator #2600
fix: Set Current Surface as first surface for direct navigator #2600
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor thing then ready to go - thanks!
new commit for fixing format. @andiwand need another approval |
Codecov Report
@@ Coverage Diff @@
## main #2600 +/- ##
==========================================
- Coverage 49.55% 49.53% -0.03%
==========================================
Files 472 472
Lines 26724 26727 +3
Branches 12318 12318
==========================================
- Hits 13244 13240 -4
- Misses 4748 4752 +4
- Partials 8732 8735 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
For a direct navigator we set the current surface to be the first surface in the surface sequence. This is done in the
DirectNavigator:Initializer::operator()