Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set Current Surface as first surface for direct navigator #2600

Conversation

CarloVarni
Copy link
Collaborator

For a direct navigator we set the current surface to be the first surface in the surface sequence. This is done in the DirectNavigator:Initializer::operator()

@CarloVarni CarloVarni added this to the next milestone Oct 31, 2023
@github-actions github-actions bot added the Component - Core Affects the Core module label Oct 31, 2023
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor thing then ready to go - thanks!

Core/include/Acts/Propagator/DirectNavigator.hpp Outdated Show resolved Hide resolved
andiwand
andiwand previously approved these changes Oct 31, 2023
@CarloVarni
Copy link
Collaborator Author

new commit for fixing format. @andiwand need another approval

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #2600 (55121f8) into main (fbc3bd8) will decrease coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is 27.42%.

@@            Coverage Diff             @@
##             main    #2600      +/-   ##
==========================================
- Coverage   49.55%   49.53%   -0.03%     
==========================================
  Files         472      472              
  Lines       26724    26727       +3     
  Branches    12318    12318              
==========================================
- Hits        13244    13240       -4     
- Misses       4748     4752       +4     
- Partials     8732     8735       +3     
Files Coverage Δ
Core/include/Acts/Geometry/CuboidVolumeBounds.hpp 62.06% <100.00%> (ø)
Core/include/Acts/Geometry/Extent.hpp 90.90% <ø> (ø)
...re/include/Acts/Geometry/SurfaceBinningMatcher.hpp 42.85% <100.00%> (ø)
Core/include/Acts/Propagator/AbortList.hpp 83.33% <ø> (ø)
Core/include/Acts/Propagator/ActionList.hpp 100.00% <ø> (ø)
...e/include/Acts/Propagator/StepperExtensionList.hpp 64.58% <ø> (ø)
Core/include/Acts/Surfaces/CylinderBounds.hpp 68.75% <100.00%> (ø)
Core/include/Acts/Surfaces/DiamondBounds.hpp 62.50% <100.00%> (ø)
Core/include/Acts/Surfaces/TrapezoidBounds.hpp 73.91% <100.00%> (ø)
Core/include/Acts/Surfaces/detail/FacesHelper.hpp 60.00% <100.00%> (ø)
... and 106 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kodiakhq kodiakhq bot merged commit 159acb7 into acts-project:main Oct 31, 2023
54 checks passed
@CarloVarni CarloVarni deleted the SetCurrentSurfaceInDirectNavigatorInitializer branch October 31, 2023 18:32
@paulgessinger paulgessinger modified the milestones: next, v31.0.0 Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants