-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Step size constraint using proper time limit for particle decays #691
Merged
asalzburger
merged 19 commits into
acts-project:master
from
FabianKlimpel:TimeConstraint
Feb 5, 2021
Merged
feat: Step size constraint using proper time limit for particle decays #691
asalzburger
merged 19 commits into
acts-project:master
from
FabianKlimpel:TimeConstraint
Feb 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabianKlimpel
added
Component - Fatras
Affects the Fatras module
Improvement
Changes to an existing feature
labels
Feb 3, 2021
msmk0
reviewed
Feb 3, 2021
Codecov Report
@@ Coverage Diff @@
## master #691 +/- ##
=======================================
Coverage 48.99% 48.99%
=======================================
Files 331 331
Lines 16549 16549
Branches 7724 7724
=======================================
Hits 8109 8109
Misses 3009 3009
Partials 5431 5431 Continue to review full report at Codecov.
|
FabianKlimpel
force-pushed
the
TimeConstraint
branch
from
February 4, 2021 07:50
a023f79
to
d05a057
Compare
FabianKlimpel
force-pushed
the
TimeConstraint
branch
from
February 4, 2021 14:32
d05a057
to
aa4a97b
Compare
msmk0
reviewed
Feb 4, 2021
msmk0
reviewed
Feb 4, 2021
This was referenced Feb 4, 2021
msmk0
approved these changes
Feb 4, 2021
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
Feb 8, 2021
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a constraint of the step size during the Fatras propagation using the proper time limit of the particle.