build: Abort build if DD4hep does not have DDDetectors #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HadrienG2
approved these changes
Feb 9, 2021
Merged
Codecov Report
@@ Coverage Diff @@
## master #708 +/- ##
=======================================
Coverage 49.02% 49.02%
=======================================
Files 325 325
Lines 16574 16574
Branches 7744 7744
=======================================
Hits 8126 8126
Misses 3017 3017
Partials 5431 5431 Continue to review full report at Codecov.
|
HadrienG2
approved these changes
Feb 10, 2021
|
Oh, apologies @paulgessinger - didn't see this as WIP and had accidently pressed the update button. |
|
I think this is good to go now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need
DDDetectorsfor the DD4hep XML loading to work. If it's not present, errors like in #706 pop up at runtime.This PR explicitly requests
DDDetectorsis available. This will fail in the CI right now, because ourubuntu2004CI image builds DD4hep without it. A fix for that is pending here: acts-project/machines#29.I will update this PR with bumped CI images for the failure to resolve.
/cc @HadrienG2