Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update mapping script #736

Merged

Conversation

Corentin-Allaire
Copy link
Contributor

This PR update the mapping script to take into account the change to the key used in the Json conversion. This will solve issue #733

@Corentin-Allaire Corentin-Allaire added Bug Something isn't working Component - Examples Affects the Examples module Impact - Minor Nuissance bug and/or affects only a single module labels Mar 1, 2021
@Corentin-Allaire Corentin-Allaire added this to the next milestone Mar 1, 2021
@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #736 (353c143) into master (213d97d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #736   +/-   ##
=======================================
  Coverage   48.94%   48.94%           
=======================================
  Files         325      325           
  Lines       16622    16622           
  Branches     7760     7760           
=======================================
  Hits         8135     8135           
  Misses       3039     3039           
  Partials     5448     5448           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 213d97d...86ca15d. Read the comment docs.

Copy link
Contributor

@HadrienG2 HadrienG2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@asalzburger asalzburger merged commit 9dd6e12 into acts-project:master Mar 2, 2021
@paulgessinger paulgessinger modified the milestones: next, v7.0.0 Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Component - Examples Affects the Examples module Impact - Minor Nuissance bug and/or affects only a single module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants