refactor: Use std::optional for event range end requested #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #790 +/- ##
=======================================
Coverage 48.65% 48.65%
=======================================
Files 328 328
Lines 16895 16895
Branches 7932 7932
=======================================
Hits 8220 8220
Misses 3078 3078
Partials 5597 5597 Continue to review full report at Codecov.
|
gagnonlg
pushed a commit
to gagnonlg/acts
that referenced
this pull request
May 11, 2021
…ct#790) Previously, SIZE_MAX was used to indicate that the full available end range of an input file was to be used. This caused issues when no input file was present (for example in the geometry examples) and --events was not given., since it would run SIZE_MAX events (see acts-project#707). This PR changes this to use std::optional<size_t>, so that the default is clearly communicated. The geometry example should now default to 1 if --events isn't supplied. Fixes acts-project#707
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
SIZE_MAXwas used to indicate that the full available end range of an input file was to be used. This caused issues when no input file was present (for example in the geometry examples) and--eventswas not given., since it would runSIZE_MAXevents (see #707).This PR changes this to use
std::optional<size_t>, so that the default is clearly communicated. The geometry example should now default to1if--eventsisn't supplied.Fixes #707